Support non-optional union types for ORC#4654
Closed
funcheetah wants to merge 2 commits intoapache:mainfrom
Closed
Support non-optional union types for ORC#4654funcheetah wants to merge 2 commits intoapache:mainfrom
funcheetah wants to merge 2 commits intoapache:mainfrom
Conversation
This was referenced Apr 27, 2022
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apache Iceberg does not support non-optional union types (e.g. [“int”, “string”]), nor does Apache Spark. This PR enables Iceberg to read non-optional union types by converting them into struct representations for Apache ORC format.
Representation
The struct representations converted from non-option union types are consistent with non-optional union support added in Trino in trinodb/trino#3483.
Deep nested non-optional union types are supported.
Examples
Basic
[“int”, “string”] -> struct<tag int, field0 int, field1 string>
Single type
[“int”] -> int
Related PRs
TODO
Add spec for non-optional union types support
Handle single type union (e.g. [“int”]) as a primitive type
Support in non-Spark environments (e.g. iceberg-data, flink, hive, etc.)
Support for schema pruning within a complex union